Skip to content

Conversation

@DatGuyJonathan
Copy link
Contributor

@DatGuyJonathan DatGuyJonathan commented Nov 4, 2025

Note

Introduce full ClickHouse cluster support: new table cluster config, ON CLUSTER DDL across migrations/ops, validations, TS/Py SDK updates, new templates and E2E tests, CI jobs, and docs updates.

  • OLAP/CLI core:
    • Add cluster_name to Table/inframap (proto, serde) and show in CLI.
    • Generate ON CLUSTER in CREATE/ALTER/DROP/SETTINGS/SAMPLE/INDEX DDL and pass cluster through all operations.
    • Do not treat cluster_name as schema-diff; preserve from infra map during reconcile.
    • Validate databases and clusters in plans/migrations; improved error messages.
    • Handle replicated engines: auto-inject params in dev when no cluster; support cluster-aware replication.
    • Update migration schema to allow structured engine objects.
  • SDKs (TypeScript/Python):
    • Add optional cluster to OLAP table config; serialize to internal model.
    • Validate that cluster cannot be combined with explicit keeperPath/replicaName (TS) or keeper_path/replica_name (Py).
    • Add unit tests for cluster validation.
  • E2E & Templates:
    • New templates templates/typescript-cluster and templates/python-cluster with clustered/non-clustered tables.
    • Add E2E tests (apps/framework-cli-e2e/test/cluster.test.ts) for infra map, CH clusters, XML generation, and table creation.
    • CI: add test-e2e-cluster-typescript and test-e2e-cluster-python jobs; adjust path filters.
  • Infra & Misc:
    • Docker compose supports mounting clickhouse_clusters.xml when provided.
  • Docs:
    • Update configuration and model-table docs to document clusters, replication modes, and deployment guidance; note in planned migrations.

Written by Cursor Bugbot for commit a201fdd. This will update automatically on new commits. Configure here.

@linear
Copy link

linear bot commented Nov 4, 2025

@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Nov 15, 2025 0:52am
framework-docs Ready Ready Preview Comment Nov 15, 2025 0:52am
moosestack-framework-docs-v2 Ready Ready Preview Comment Nov 15, 2025 0:52am

@DatGuyJonathan DatGuyJonathan force-pushed the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch from 21fe7ee to c6c3954 Compare November 4, 2025 16:51
@DatGuyJonathan DatGuyJonathan force-pushed the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch from 7bb0782 to 069ebb6 Compare November 4, 2025 19:08
@DatGuyJonathan DatGuyJonathan force-pushed the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch from f7f8c50 to 5933a0f Compare November 4, 2025 21:10
@DatGuyJonathan DatGuyJonathan force-pushed the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch from 5933a0f to c3f78b3 Compare November 4, 2025 23:46
@DatGuyJonathan DatGuyJonathan force-pushed the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch from c3f78b3 to 23daf2e Compare November 5, 2025 04:52
@DatGuyJonathan DatGuyJonathan force-pushed the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch from 00d184c to cc21483 Compare November 5, 2025 16:53
@DatGuyJonathan DatGuyJonathan force-pushed the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch from ac3c6a4 to 651a7c7 Compare November 6, 2025 22:19
@DatGuyJonathan DatGuyJonathan force-pushed the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch from 10dee31 to a201fdd Compare November 15, 2025 00:51
@DatGuyJonathan DatGuyJonathan added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 6cc7a8b Nov 17, 2025
86 of 88 checks passed
@DatGuyJonathan DatGuyJonathan deleted the eng-1117-add-on-cluster-support-for-replicated-clickhouse-tables branch November 17, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants